Remove Angular support - #39

@earlAchromatic+SAGE reviewed 16 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on earlAchromatic and pkaminski).

src/Modeler.js line 95 at r1 (raw file):

      return expression.call(this);
    }, options);
    promiseFinally(promise, () => {this.$off('hook:destroyed', promise.cancel);});

This leaves a rejected child promise unhandled once the paired client stops replacing native Promise with Angular’s $q. promiseFinally() returns a new promise that re-rejects after cleanup, but $when() discards that child and returns promise, so handling what the caller receives does not handle the cleanup branch. $nextTick() repeats the pattern at line 133.

I reproduced this on the paired heads. From a loaded local review, the minimal trigger is:

window.truss.store.$when(() => false, {timeout: 25}).catch(_.noop);

For the real UI path, I temporarily forced AnimateReflow’s condition to remain false while preserving its ten-second timeout. AnimateReflow handled the expected Timeout, but Reviewable still opened the blocking crash overlay with Timeout; corpsman.signalCrash() suspended Truss and locked navigation and hotkeys.

Could we retain and return the finalized promise in both methods, as $peek() does above?

@pkaminski+CODX made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on earlAchromatic+SAGE).

src/Modeler.js line 95 at r1 (raw file):

Fixed by retaining and returning the promise produced by promiseFinally() in both $when() and $nextTick(), matching $peek()'s pattern. This keeps cancel propagation intact while ensuring that handling the returned rejection also handles the cleanup branch. I added regression coverage for both methods that verifies the finalized promise is returned, cancel is preserved, the rejection is handled through that returned promise, and the destruction hook is removed after settlement. yarn lint and all 24 tests pass.